Fixed CLI output when running post_write hooks #1262
Conversation
|
Thanks. Maybe we could use f-strints tough? |
Sure. I was worried about compatibility with lower Python versions but found out Alembic support 3.7+. No worries then. Shall I update all occurrences in the file? Don't know what the policy is concerning updating outdated code. |
As you prefer |
|
Done. Let me know |
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 19d17f5 of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change 19d17f5: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4731 |
|
mike bayer (zzzeek) wrote: hi and thanks for this! as trivial as this is, it fixes a user-facing bug so likely needs a changelog. otherwise peopel dont know what they are getting when they download a newer version View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4731 |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4731 has been merged. Congratulations! :) |
|
Federico Caselli (CaselIT) wrote: updated the change log. Sadly I did commit & push and it merged it.. git review -d id sets the upstream to main 😞 View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4731 |
Fixes: #1261
Description
Just fixed badly written Python string interpolation. Used the
%operator just like the lines above.Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageHave a nice day!